Still a lot to be done, but I'm going to bed.

Two remaining big issues:
* aplwc (the parameter passed "everywhere") - should it move or not?
* values returned from the public API should not move.

FossilOrigin-Name: 31ab3154b8f3d5ac167218496e9e204324bf0ac9d36b7bada8fe2a6c8f93d51c

5 files changed, 112 insertions, 45 deletions

diff --git a/tests/aplwc_errstr.c b/tests/aplwc_errstr.c
index 2ca14ab..1a5ebc4 100644
--- a/tests/aplwc_errstr.c
+++ b/tests/aplwc_errstr.c
@@ -1,47 +1,76 @@
-#include <aplwc.h>
+#include <stdlib.h>
 #include <string.h>
+#include <aplwc.h>
+
+static void *
+my_alloc(size_t min, size_t max, size_t *actual)
+{
+	(void)max;
+
+	*actual = min;
+	return malloc(min);
+}
+
+static void
+my_dealloc(void *p)
+{
+	free(p);
+}
 
 int
 main(void)
 {
-	uint8_t data[20000];
+	struct aplwc_fns fns;
 	struct aplwc *aplwc;
-	int ret;
+	int ret, success;
 	const char *err;
 
-	ret = aplwc_new(&aplwc, data, sizeof(data));
+	success = 0;
+	aplwc = NULL;
+
+	memset(&fns, 0, sizeof(fns));
+	fns.alloc = my_alloc;
+	fns.dealloc = my_dealloc;
+
+	ret = aplwc_new(&aplwc, fns);
 	if(ret)
-		return 1;
+		goto end;
 
 	err = aplwc_errstr(aplwc);
 	if(err == NULL)
-		return 1;
+		goto end;
 
 	if(strlen(err) != 0)
-		return 1;
+		goto end;
 
 	err = aplwc_errstr(NULL);
 	if(err == NULL)
-		return 1;
+		goto end;
 	if(strcmp(err, "(unable to produce error string)") != 0)
-		return 1;
+		goto end;
 
 	aplwc_destroy(aplwc);
+	aplwc = NULL;
 
-	ret = aplwc_new(&aplwc, data, 0);
+	fns.alloc = NULL;
+	ret = aplwc_new(&aplwc, fns);
 	if(ret == 0)
-		return 1;
+		goto end;
 	err = aplwc_errstr_rc(ret);
 	if(err == NULL)
-		return 1;
+		goto end;
 
 	for(ret = 0; ret <= APLWC_RC_LAST; ret++){
 		err = aplwc_errstr_rc(ret);
 		if(err == NULL)
-			return 1;
+			goto end;
 		if(strcmp(err, "(unable to produce error string)") == 0)
-			return 1;
+			goto end;
 	}
 
-	return 0;
+	success = 1;
+end:
+	if(aplwc)
+		aplwc_destroy(aplwc);
+	return !success;
 }
diff --git a/tests/aplwc_eval.c b/tests/aplwc_eval.c
index c284189..68ea4a8 100644
--- a/tests/aplwc_eval.c
+++ b/tests/aplwc_eval.c
@@ -1,15 +1,31 @@
 #include <stdio.h>
 #include <stdlib.h>
+#include <string.h>
 #include <aplwc.h>
 
+static void *
+my_alloc(size_t min, size_t max, size_t *actual)
+{
+	(void)max;
+
+	*actual = min;
+	return malloc(min);
+}
+
+static void
+my_dealloc(void *p)
+{
+	free(p);
+}
+
 int
 main(int argc, char *argv[])
 {
-	uint8_t data[64000];
 	char *input;
 	struct aplwc *aplwc;
 	struct aplwc_line *line;
 	struct aplwc_value *value;
+	struct aplwc_fns fns;
 	enum aplwc_rc ret;
 	FILE *f;
 	long input_size;
@@ -35,7 +51,12 @@ main(int argc, char *argv[])
 		return 1;
 	input[input_size] = 0;
 
-	ret = aplwc_new(&aplwc, data, sizeof(data));
+
+	memset(&fns, 0, sizeof(fns));
+	fns.alloc = my_alloc;
+	fns.dealloc = my_dealloc;
+
+	ret = aplwc_new(&aplwc, fns);
 	if(ret)
 		return 1;
 
diff --git a/tests/aplwc_new.c b/tests/aplwc_new.c
deleted file mode 100644
index 4ed893e..0000000
--- a/tests/aplwc_new.c
+++ /dev/null
@@ -1,24 +0,0 @@
-#include <aplwc.h>
-
-int
-main(void)
-{
-	struct aplwc *aplwc;
-	uint8_t data[10000];
-	int ret;
-	size_t i, j;
-
-	for(i = 0; i < 32; i++){
-		for(j = 0; j <= sizeof(data)-i; j++){
-			ret = aplwc_new(&aplwc, data+i, j);
-			aplwc_destroy(aplwc);
-			if(ret){
-				if(ret != APLWC_OUT_OF_MEMORY)
-					return 1;
-				break;
-			}
-		}
-	}
-	
-	return 0;
-}
diff --git a/tests/aplwc_read.c b/tests/aplwc_read.c
index 8c5ce37..42a47c2 100644
--- a/tests/aplwc_read.c
+++ b/tests/aplwc_read.c
@@ -1,11 +1,27 @@
 #include <stdio.h>
 #include <stdlib.h>
+#include <string.h>
 #include <aplwc.h>
 
+static void *
+my_alloc(size_t min, size_t max, size_t *actual)
+{
+	(void)max;
+
+	*actual = min;
+	return malloc(min);
+}
+
+static void
+my_dealloc(void *p)
+{
+	free(p);
+}
+
 int
 main(int argc, char *argv[])
 {
-	uint8_t data[20000];
+	struct aplwc_fns fns;
 	char *input;
 	struct aplwc *aplwc;
 	struct aplwc_line *line;
@@ -13,6 +29,10 @@ main(int argc, char *argv[])
 	FILE *f;
 	long input_size;
 
+	memset(&fns, 0, sizeof(fns));
+	fns.alloc = my_alloc;
+	fns.dealloc = my_dealloc;
+
 	if(argc != 2)
 		return 1;
 
@@ -33,7 +53,7 @@ main(int argc, char *argv[])
 		return 1;
 	input[input_size] = 0;
 	
-	ret = aplwc_new(&aplwc, data, sizeof(data));
+	ret = aplwc_new(&aplwc, fns);
 	if(ret)
 		return 1;
 
diff --git a/tests/aplwc_utf8.c b/tests/aplwc_utf8.c
index b950580..4f9f2a4 100644
--- a/tests/aplwc_utf8.c
+++ b/tests/aplwc_utf8.c
@@ -1,3 +1,5 @@
+#include <stdlib.h>
+#include <string.h>
 #include <aplwc.h>
 
 uint8_t bad1[] = {0xff,0};
@@ -14,12 +16,27 @@ uint8_t good3[] = {0xed,0x95,0x9c,0xea,0xb5,0xad,0xec,0x96,0xb4,0};
 uint8_t good4[] = {0xe6,0x97,0xa5,0xe6,0x9c,0xac,0xe8,0xaa,0x9e,0};
 uint8_t good5[] = {0xef,0xbb,0xbf,0xf0,0xa3,0x8e,0xb4,0};
 
+static void *
+my_alloc(size_t min, size_t max, size_t *actual)
+{
+	(void)max;
+
+	*actual = min;
+	return malloc(min);
+}
+
+static void
+my_dealloc(void *p)
+{
+	free(p);
+}
+
 int
 main(void)
 {
-	uint8_t data[64000];
 	struct aplwc *aplwc;
 	struct aplwc_line *line;
+	struct aplwc_fns fns;
 	enum aplwc_rc ret;
 	size_t i;
 
@@ -41,7 +58,11 @@ main(void)
 		good5
 	};
 
-	ret = aplwc_new(&aplwc, data, sizeof(data));
+	memset(&fns, 0, sizeof(fns));
+	fns.alloc = my_alloc;
+	fns.dealloc = my_dealloc;
+
+	ret = aplwc_new(&aplwc, fns);
 	if(ret)
 		return 1;