From f9f9b10c1d17077632d7a09e447e629b8d33b23d Mon Sep 17 00:00:00 2001
From: peter <peter@pmikkelsen.com>
Date: Mon, 31 Aug 2026 20:21:54 +0000
Subject: A little bit of testing

FossilOrigin-Name: 70deba994bb488d4aa5df36577d1e184d6651a3edeff042e9666f54589cdc6f9
---
 CMakeLists.txt             | 16 ++++++++++++----
 src/lib/main.c             |  4 ++--
 tests/scripts/1.aplwc      |  5 -----
 tests/scripts/2.aplwc      |  9 ---------
 tests/scripts/bad/1.aplwc  |  1 +
 tests/scripts/bad/2.aplwc  |  1 +
 tests/scripts/bad/3.aplwc  |  1 +
 tests/scripts/good/1.aplwc |  5 +++++
 tests/scripts/good/2.aplwc |  9 +++++++++
 9 files changed, 31 insertions(+), 20 deletions(-)
 delete mode 100755 tests/scripts/1.aplwc
 delete mode 100755 tests/scripts/2.aplwc
 create mode 100755 tests/scripts/bad/1.aplwc
 create mode 100755 tests/scripts/bad/2.aplwc
 create mode 100755 tests/scripts/bad/3.aplwc
 create mode 100755 tests/scripts/good/1.aplwc
 create mode 100755 tests/scripts/good/2.aplwc

diff --git a/CMakeLists.txt b/CMakeLists.txt
index 2cda996..9da17b3 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -100,19 +100,27 @@ foreach(source ${TEST_SOURCES})
 	endif()
 endforeach()
 
-file(GLOB TEST_SCRIPTS CONFIGURE_DEPENDS "tests/scripts/*.aplwc")
-foreach(script ${TEST_SCRIPTS})
+file(GLOB TEST_SCRIPTS_GOOD CONFIGURE_DEPENDS "tests/scripts/good/*.aplwc")
+foreach(script ${TEST_SCRIPTS_GOOD})
 	add_test(NAME "${script}" COMMAND "${script}")
 	set_tests_properties("${script}" PROPERTIES
-		ENVIRONMENT "APLWC_MEM=64000;PATH=$<TARGET_FILE_DIR:aplwc-repl>"
+		ENVIRONMENT "PATH=$<TARGET_FILE_DIR:aplwc-repl>"
 	)
 
 	add_test(NAME "aplwc-repl ${script}" COMMAND "aplwc-repl" "${script}")
 	set_tests_properties("aplwc-repl ${script}" PROPERTIES
-		ENVIRONMENT "APLWC_MEM=64000;PATH=$<TARGET_FILE_DIR:aplwc-repl>"
+		ENVIRONMENT "PATH=$<TARGET_FILE_DIR:aplwc-repl>"
 	)
 endforeach()
 
+file(GLOB TEST_SCRIPTS_BAD CONFIGURE_DEPENDS "tests/scripts/bad/*.aplwc")
+foreach(script ${TEST_SCRIPTS_BAD})
+	add_test(NAME "aplwc-repl ${script}" COMMAND "aplwc-repl" "${script}")
+	set_tests_properties("aplwc-repl ${script}" PROPERTIES
+		ENVIRONMENT "PATH=$<TARGET_FILE_DIR:aplwc-repl>"
+		WILL_FAIL TRUE
+	)
+endforeach()
 
 add_test(NAME "aplwc-repl" COMMAND "aplwc-repl" "-x")
 
diff --git a/src/lib/main.c b/src/lib/main.c
index dcf4a1c..4571c78 100644
--- a/src/lib/main.c
+++ b/src/lib/main.c
@@ -26,8 +26,8 @@ aplwc_new(struct aplwc_fns fns, enum aplwc_rc *rcp)
 end:
 	if(rc != APLWC_OK)
 		aplwc_destroy(aplwc);
-	if(rcp)
-		*rcp = rc;
+	assert(rcp);
+	*rcp = rc;
 	return aplwc;
 }
 
diff --git a/tests/scripts/1.aplwc b/tests/scripts/1.aplwc
deleted file mode 100755
index e101d02..0000000
--- a/tests/scripts/1.aplwc
+++ /dev/null
@@ -1,5 +0,0 @@
-#!/usr/bin/env aplwc-repl
-
-∇ run
-⎕←40 + 2
-∇
diff --git a/tests/scripts/2.aplwc b/tests/scripts/2.aplwc
deleted file mode 100755
index e60e717..0000000
--- a/tests/scripts/2.aplwc
+++ /dev/null
@@ -1,9 +0,0 @@
-#!/usr/bin/env aplwc-repl
-
-∇ run
-  foo 123
-∇
-
-∇ foo x
-  ⎕←x+x
-∇
diff --git a/tests/scripts/bad/1.aplwc b/tests/scripts/bad/1.aplwc
new file mode 100755
index 0000000..792d600
--- /dev/null
+++ b/tests/scripts/bad/1.aplwc
@@ -0,0 +1 @@
+#
diff --git a/tests/scripts/bad/2.aplwc b/tests/scripts/bad/2.aplwc
new file mode 100755
index 0000000..1e0a14c
--- /dev/null
+++ b/tests/scripts/bad/2.aplwc
@@ -0,0 +1 @@
+!#
diff --git a/tests/scripts/bad/3.aplwc b/tests/scripts/bad/3.aplwc
new file mode 100755
index 0000000..ba38a01
--- /dev/null
+++ b/tests/scripts/bad/3.aplwc
@@ -0,0 +1 @@
+##
diff --git a/tests/scripts/good/1.aplwc b/tests/scripts/good/1.aplwc
new file mode 100755
index 0000000..e101d02
--- /dev/null
+++ b/tests/scripts/good/1.aplwc
@@ -0,0 +1,5 @@
+#!/usr/bin/env aplwc-repl
+
+∇ run
+⎕←40 + 2
+∇
diff --git a/tests/scripts/good/2.aplwc b/tests/scripts/good/2.aplwc
new file mode 100755
index 0000000..e60e717
--- /dev/null
+++ b/tests/scripts/good/2.aplwc
@@ -0,0 +1,9 @@
+#!/usr/bin/env aplwc-repl
+
+∇ run
+  foo 123
+∇
+
+∇ foo x
+  ⎕←x+x
+∇
-- 
cgit v1.2.3